Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): eliminate aws service request time from latencies.kong #12678

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Mar 1, 2024

Summary

As per FTI-5261's report, it is unexpected that the external request time of AWS lambda service is also being added to latencies.kong latency number, which is part of our serialized log data and being used by some of our monitoring plugins, such as datadog.

This PR tries to eliminate the AWS related request time from latencies.kong, by adding a new ctx variable ctx.KONG_THIRDPARTY_ACCESS_TIME. Since this problem is not a special one, we have a similar situation in many other plugins/vaults that requires external access(such as external IdP, secret management service, etc.). We can also add those things into ctx.KONG_THIRDPARTY_ACCESS_TIME so that we can tracking external 3rd-party service's latency, as well as subtracting them from Kong's latency number.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

https://konghq.atlassian.net/browse/FTI-5261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant