refactor(globalpatches): remove the compatibility code for the sock:connect bug #12248
+1
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD-SP
approved these changes
Dec 26, 2023
AndyZhang0707
approved these changes
Dec 26, 2023
dndx
approved these changes
Dec 26, 2023
AndyZhang0707
force-pushed
the
remove_deprecated_code
branch
from
48ae82d to
28d130f
Compare
ADD-SP
changed the title
dndx
force-pushed
the
remove_deprecated_code
branch
from
28d130f to
f2728ea
Compare
chobits
force-pushed
the
remove_deprecated_code
branch
2 times, most recently
from
6027b16 to
1daa21d
Compare
…ect bug The official OpenResty has fixed the bug of sock:connect API, so we do not need to make it compatible for this. For more details of this bug, see openresty/lua-nginx-module#860.
chobits
force-pushed
the
remove_deprecated_code
branch
from
1daa21d to
0393b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The official OpenResty has fixed the bug of sock:connect API, so we do not need to make it compatible for this. For more details of this bug, see openresty/lua-nginx-module#860.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]