Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(conf): client_max_body_size to 10m by default #12229

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bungle
Copy link
Member

@bungle bungle commented Dec 20, 2023

Summary

Important Changed the default value of nginx_http_client_max_body_size in Kong configuration from 0 (unbounded) to 10m (10 megabytes).

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-3361

@bungle bungle force-pushed the chore/proxy-max-body-size branch from 1eff691 to b67c1db Compare April 23, 2024 16:48
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 23, 2024
@bungle bungle force-pushed the chore/proxy-max-body-size branch from b67c1db to b290094 Compare April 24, 2024 08:12
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 24, 2024
@bungle bungle marked this pull request as ready for review April 24, 2024 08:13
@bungle bungle force-pushed the chore/proxy-max-body-size branch from b290094 to 4ad46e8 Compare April 24, 2024 08:13
@bungle bungle added this to the 3.7.0 milestone Apr 24, 2024
@bungle
Copy link
Member Author

bungle commented Apr 24, 2024

@kikito / @hbagdi what is final decision: merge or not merge this on 3.7? It may break some installations that deal with large client bodies (larger than 10mb).

@kikito kikito marked this pull request as draft April 24, 2024 09:28
@kikito
Copy link
Member

kikito commented Apr 24, 2024

Changing this to draft while we discuss on the internal ticket.

message: |
**Important** Changed the default value of `nginx_http_client_max_body_size` in
Kong configuration from `0` (unbounded) to `10m` (10 megabytes).
type: bugfix
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the type be "breaking_change"?

@locao locao removed this from the 3.7.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants