-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmd): move unix domain sockets to /var/run #11944
base: master
Are you sure you want to change the base?
Conversation
904de06
to
9159137
Compare
e6aae4e
to
615944a
Compare
e5d21a2
to
dca52e6
Compare
@@ -44,22 +44,6 @@ if [[ "$1" == "kong" ]]; then | |||
if [[ "$2" == "docker-start" ]]; then | |||
kong prepare -p "$PREFIX" "$@" | |||
|
|||
# remove all dangling sockets in $PREFIX dir before starting Kong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will still need the logic, but instead removing dangling sockets in /var/run/kong directory.
I was wrong with my previous comment some days ago, it appears the /run
or /var/run
directory is not a volatile fs inside container; it's only volatile in a normal system. So the contents under this directory persists between container restarts.
Please also consider use cases when user doesn't start Kong through In conclusion, we need to consider following use cases:
|
df08f4f
to
72b9a53
Compare
… and runtime dir locations
…or dangling sockets
72b9a53
to
8a5a1ba
Compare
Summary
Unix domain socket files located in the prefix directory cause problems when mounting that directory in containers. In addition, it is common practice to store socket files in /var/run which is cleaned up automatically on server restart.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
Fix KAG-328