feat(clustering): entity streaming based cp-dp protocol with lmdb streaming #11632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
added
pr/do not merge
pr/discussion
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
from
528e985 to
9253769
Compare
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
5 times, most recently
from
1d0e871 to
42a038d
Compare
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
8 times, most recently
from
b4a9c5a to
6b7880a
Compare
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
3 times, most recently
from
97f3aa4 to
1ddff8f
Compare
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
7 times, most recently
from
052e375 to
5fa3bdc
Compare
|
Not coming to 3.5 |
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
from
5fa3bdc to
a98e1aa
Compare
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
3 times, most recently
from
0e39c53 to
7e0dc8a
Compare
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
7 times, most recently
from
2ad9db5 to
ebbad2a
Compare
Signed-off-by: Aapo Talvensaari <[email protected]>
### Summary Uses streaming protocol for CP-DP reconfigure to avoid huge blob inflation/deflation + json encoding/decoding. Signed-off-by: Aapo Talvensaari <[email protected]>
### Summary Removes a lot of unneeded processing from the data plane side by streaming reconfigure data directly to lmdb transaction, and instead of doing full declarative config validation/flattening etc. it just does entity level validation (the entity level validation on DP side we can remove later on, if we decide so). Signed-off-by: Aapo Talvensaari <[email protected]>
### Summary Skip full validation of entities and validate the fields only. Before: ``` [clustering] received updated configuration from control plane: 17291 ms ``` After: ``` [clustering] received updated configuration from control plane: 11213 ms ``` Signed-off-by: Aapo Talvensaari <[email protected]>
Signed-off-by: Aapo Talvensaari <[email protected]>
… entities Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
force-pushed
the
feat/cp-dp-entity-streaming
branch
from
ebbad2a to
c90a5aa
Compare
Signed-off-by: Aapo Talvensaari <[email protected]>
3 tasks
…es in smaller space Signed-off-by: Aapo Talvensaari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR #11630 adds streaming protocol for CP-DP reconfigure to avoid huge blob inflation/deflation + json encoding/decoding. This PR includes that and goes one step further and also streams entities directly to lmdb transaction, and moves to entity level validation only (thus a lot of "unneccessary" processing is removed from DP side).
KAG-2673
KAG-2670
KAG-2676