fix: ensuring consumer-group scoped plugins show tags #151
Conversation
Prashansa-K
force-pushed
the
fix/cg-plugin-tags
branch
from
8c0098e to
d27b3fb
Compare
On running `deck file render` command, tags were coming up for global and service/route scoped plugins, but not for consumer-group scoped ones. This was because the underlying struct that were using for writer did not have `Tags` as a field. This change was added in the underlying type in go-kong. This change upgrades the go-kong version to v0.61.0 and adds `Tags` field in all missing places while building consumer-group scoped plugins or writing them to file. For: https://konghq.atlassian.net/browse/FTI-6292
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
- Coverage 28.72% 28.71% -0.01%
==========================================
Files 106 106
Lines 15814 15817 +3
==========================================
Hits 4542 4542
- Misses 10793 10796 +3
Partials 479 479 ☔ View full report in Codecov by Sentry. |
Prashansa-K
force-pushed
the
fix/cg-plugin-tags
branch
from
d27b3fb to
9cb130c
Compare
Prashansa-K
force-pushed
the
fix/cg-plugin-tags
branch
from
937bf8d to
1e4d215
Compare
There was a problem hiding this comment.
Any particular reason for xxx in the name :) ?
There was a problem hiding this comment.
Just following the recent convention. Earlier folders were numbered, but then xxx became the prefix.
I assumed we did so because we had already reached 35 folders.
There was a problem hiding this comment.
ACK. Is 35 a magic number of sorts for us ? 🙃 Nothing against the prefix, just curious.
There was a problem hiding this comment.
😂 No! I can change the name. As I said, I just looked at the last few entries and added the xxx
Summary
On running
deck file rendercommand, tagswere coming up for global and service/route
scoped plugins, but not for consumer-group
scoped ones. This was because the underlying
struct that were using for writer did not have
Tagsas a field. This change was added in theunderlying type in go-kong.
This change upgrades the go-kong version to
v0.61.0 and adds
Tagsfield in all missingplaces while building consumer-group scoped
plugins or writing them to file.
Issues resolved
For: https://konghq.atlassian.net/browse/FTI-6292
Documentation
Testing