feat(jq): parse input early and reuse filter instance #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves filter compilation from NodeFactory::new_node() into NodeFactory::new_config(). This gives us earlier feedback on invalid filter string user input and moves the costly filter compilation step out of the request path. We don't need an owned j[a]q filter object to execute it, so instead of creating a new instance in NodeFactory::new_node(), we're just using std::rc::Rc to maintain a shared reference. Making these changes effectively removed the differences between the Jq and JqConfig structs, so I just removed JqConfig and implemented NodeConfig for Rc<Jq> instead.
flrgh
force-pushed
the
chore/jq-filter-reuse
branch
from
14a029c
to
51d1dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves filter compilation from
NodeFactory::new_node()intoNodeFactory::new_config(). Now we have input validation and filter compilation inon_configureinstead of in the request path.We don't need an owned j[a]q filter object to execute it, so instead of creating a new instance in
NodeFactory::new_node(), we're just usingstd::rc::Rcto maintain a shared reference.Making these changes effectively removed the differences between the
JqandJqConfigstructs, so I just removedJqConfigand implementedNodeConfigforRc<Jq>instead.Haven't really looked into the perf implications of nested pointers (
Box<Rc<Jq>>) yet (I feel like there's certainly a type system way around this), but whatever it is I'm sure it's still better than what the code was doing prior.