Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply .address equally across listens #881

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Apply .address equally across listens #881

merged 2 commits into from
Sep 12, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Sep 12, 2023

What this PR does / why we need it:

Honors the .address across listens. Some of these previously had special cases that forced their address to a hardcoded value.

Creates a new release.

Which issue this PR fixes

IPv6 support with hardcoded v4 addresses was difficult.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

Improve support for non-default addresses for listens. The admin,
stream, and controller webhook listens now honor the .address parameter.
@rainest rainest requested a review from a team as a code owner September 12, 2023 00:12
@rainest
Copy link
Contributor Author

rainest commented Sep 12, 2023

With this PR:

$ helm template ana /tmp/symkong -f /tmp/v6.yaml --set proxy.address=[::] --set admin.address=[::1] --set status.address=[::] --set cluster.address=[::] --set ingressController.admissionWebhook.address=[::] | grep -A1 _LISTEN                                                                                                                                                                                  

        - name: KONG_ADMIN_LISTEN
          value: "[::1]:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "[::]:9000"
--
        - name: CONTROLLER_ADMISSION_WEBHOOK_LISTEN
          value: "[::]:8080"
--
        - name: KONG_ADMIN_LISTEN
          value: "[::1]:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "[::]:9000"

versus

$ helm template ana kong/kong -f /tmp/v6.yaml --set proxy.address=[::] --set admin.address=[::1] --set status.address=[::] --set cluster.address=[::] --set ingressController.admissionWebhook.address=[::] | grep -A1 _LISTEN                   
        - name: KONG_ADMIN_LISTEN
          value: "127.0.0.1:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "0.0.0.0:9000"
--
        - name: CONTROLLER_ADMISSION_WEBHOOK_LISTEN
          value: "0.0.0.0:8080"
--
        - name: KONG_ADMIN_LISTEN
          value: "127.0.0.1:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "0.0.0.0:9000"

@rainest rainest enabled auto-merge (rebase) September 12, 2023 00:15
@rainest rainest merged commit db40df9 into main Sep 12, 2023
18 checks passed
@rainest rainest deleted the feat/v6-compat branch September 12, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants