Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci) test against older KIC/Kong versions #871

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Aug 21, 2023

What this PR does / why we need it:

Adds a second integration tests matrix for testing older versions.

Special notes for your reviewer:

Rather stuck because this is already broken due to the ingress chart incompatibility with KIC 2.10 and Kong 3.3 unless you override the readiness endpoint. Unless we can figure out a clever fix to that, this will just fail CI.

Ideally, this would avoid needing to set these versions manually and the duplicated integration KIND version setting. For the former two, it's unfortunately not fun to reach into the values.yaml and extract the current value and subtract from it, though sort of possible with YAML parsing and some sort of semver math tool (ignoring going below minor x.0).

Also, condensing the test list shown on the PR Actions preview would be nice. There are a lot of them now.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@rainest rainest force-pushed the old-integration branch 5 times, most recently from 51c22fb to 3120237 Compare August 21, 2023 23:10
@rainest rainest marked this pull request as ready for review September 5, 2023 19:07
@rainest rainest requested a review from a team as a code owner September 5, 2023 19:07
@rainest
Copy link
Contributor Author

rainest commented Sep 5, 2023

2.10 now has backports that handle the 3.3 endpoint gracefully; I don't plan to add the same for 2.9. This thus only includes one old KIC version for now, but we can add N versions back going forward depending on what we need to catch.

@randmonkey randmonkey merged commit 62a79bf into main Sep 19, 2023
22 checks passed
@randmonkey randmonkey deleted the old-integration branch September 19, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants