Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add kube-linter #751

Merged
merged 3 commits into from
Feb 17, 2023
Merged

chore(ci): add kube-linter #751

merged 3 commits into from
Feb 17, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Feb 16, 2023

What this PR does / why we need it:

Adds a linting step to the PR workflow that runs kube-linter. It employs various "best practices" checks that I think might make sense to test against: https://docs.kubelinter.io/#/generated/checks.

For now, I exclude all the failing checks. Let's tackle them one by one in this tracking issue: #753.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • Commits follow the Kong commit message guidelines

@czeslavo czeslavo mentioned this pull request Feb 16, 2023
6 tasks
@czeslavo czeslavo force-pushed the kube-linter branch 5 times, most recently from fd44239 to e6a5b45 Compare February 16, 2023 20:17
@czeslavo czeslavo self-assigned this Feb 16, 2023
@czeslavo czeslavo marked this pull request as ready for review February 16, 2023 20:25
@czeslavo czeslavo requested a review from a team as a code owner February 16, 2023 20:25
@czeslavo czeslavo merged commit 4c59342 into main Feb 17, 2023
@czeslavo czeslavo deleted the kube-linter branch February 17, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants