Various improvements #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The man page generation was moved to the `cfg_me` tool and thus having the feature enabled just wastes compile time and causes people problems with `cargo_toml` yanking the crates frequently. Remove it from defaults and document what it's for.
This can reduce the dependency tree if 1.0.0 is used elsewhere in the crate and it looks better to depend on a stable version.
The library was created when `#[non_exhaustive]` didn't exist and contained hacks to simulate it. This change removes the hacks in favor of `non_exhaustive`.
`std` now has a dedicated type that makes the `void` crate obsolete. Remove the dependency.
`Defaults` really represents user input and is not processed after input validation, therefore the struct belongs to the `raw` module.
There were warnings emitted when the feature was off and it also contained some deprecated stuff. Remove the deprecated functions and feature gate the rest of the code to avoid warnings.
Kixunil
added
enhancement
Previously there was a requirement to add `#[macro_use] extern crate configure_me` in the crate which made usage annoying but supported older versions of Rust which were unable to use paths in macro invocations. Such old versions of Rust are no longer supported therefore we can safely drop the requirement to have that declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.