Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More trait impls #7

Open
Kixunil opened this issue Jul 31, 2022 · 2 comments
Open

More trait impls #7

Kixunil opened this issue Jul 31, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Kixunil
Copy link
Owner

Kixunil commented Jul 31, 2022

We could and probably should derive/implement more things:

  • Clone for Uri
  • rewrite derive on Param to print string or bytes (hex encoded?)
  • Probably also (Partial)Eq and Hash
@Kixunil Kixunil added enhancement New feature or request good first issue Good for newcomers labels Jul 31, 2022
@DanGould DanGould mentioned this issue Jul 31, 2022
Merged
@DanGould
Copy link
Contributor

DanGould commented Nov 7, 2022

I think we also want Display on Uri<'a> so that we can pass around a validated and present a uri.to_string()

@Kixunil
Copy link
Owner Author

Kixunil commented Nov 8, 2022

Display is already implemented

@benthecarman benthecarman mentioned this issue Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kixunil @DanGould