Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Debug #5

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Derive Debug #5

merged 1 commit into from
Jul 31, 2022

Conversation

DanGould
Copy link
Contributor

In consuming the library at the PayJoin crate, Url not deriving Debug caused compilation issues in a complete example at unwraps

In consuming the library at the PayJoin crate, Url not deriving Debug caused compilation issues.
@DanGould
Copy link
Contributor Author

Please consider merging change.

It is necessary for payjoin:

https://github.com/Kixunil/payjoin/blob/ee91313da7d1996462c949f3a3cb3cb59c711bd7/bip78/tests/integration.rs#L43-L48

We need to

let pj_uri = pj_uri.check_pj_supoprted().expect("Bad Uri");

in order to parse in payjoin params

Copy link
Owner

@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It'd be better to impl Param manually and nicer but this is acceptable for now.

@Kixunil Kixunil merged commit 6a617b2 into Kixunil:master Jul 31, 2022
@DanGould
Copy link
Contributor Author

I'm now seeing you asked for this here

DanGould added a commit to DanGould/bip21 that referenced this pull request Dec 2, 2024
Replace is_some_and with map_or for MSRV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants