Add type hints in trame/app/__init__.py #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks for your contribution. I will rework the commit message so the CI can capture your contribution to the changelog and trigger a new version. |
kmarchais
commented
Jun 19, 2024
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| set_default_client_type("vue3") | ||
|
|
||
|
|
||
| def apply_client_type(server, client_type=None): | ||
| def apply_client_type(server: Server, client_type: str | None = None) -> Server: |
There was a problem hiding this comment.
Maybe client_type: Literal["vue2", "vue3"] instead of str?
There was a problem hiding this comment.
yes I guess that will be more precise.
There was a problem hiding this comment.
Sorry about this late change, should I open a new PR?
There was a problem hiding this comment.
Yes, but are you planning for other API typing? If so, you may want to bundle that with some more changes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type hints to the
trame/app/__init__.pyfile so thatget_clientandget_serverhave type hints.