Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix bad network until a project is opened #2661

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Jun 16, 2024

Will fix #2610 and add tauri e2e test to check on the network indicator.

Merge #2659 first

Copy link

qa-wolf bot commented Jun 16, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jul 3, 2024 0:44am

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.51%. Comparing base (34c5c15) to head (ede39b4).
Report is 3 commits behind head on main.

Current head ede39b4 differs from pull request most recent head d9058c9

Please upload reports for the commit d9058c9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
+ Coverage   86.54%   87.51%   +0.96%     
==========================================
  Files          60       56       -4     
  Lines       22823    22191     -632     
==========================================
- Hits        19752    19420     -332     
+ Misses       3071     2771     -300     
Flag Coverage Δ
wasm-lib 87.51% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +126 to +131
<ModelingMachineProvider>
<Outlet />
<Home />
<CommandBar />
</ModelingMachineProvider>
<WasmErrBanner />
Copy link
Collaborator Author

@pierremtb pierremtb Jun 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that this does the trick only when you open the app signed in. Works after a refresh after signing in, which is probably why the test fails

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah forcing a refresh after auth makes the test happy.

@lf94 @franknoirot The way I tried to enable the engine connection on the home page here was a complete shot in the dark. Let me know how you'd want to proceed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, sorry for the dirty diff here. We should merge #2659 first

@lf94
Copy link
Contributor

lf94 commented Jun 16, 2024

I can check this when Im home in 3hr. Still wip?

@pierremtb
Copy link
Collaborator Author

pierremtb commented Jun 16, 2024 via email

@lf94
Copy link
Contributor

lf94 commented Jun 16, 2024

Ah ok, it should work after first sign in I think to move forward on this but good initial work

@franknoirot
Copy link
Collaborator

Just merged #2659!

@pierremtb
Copy link
Collaborator Author

@franknoirot Thank you! Updating

@Irev-Dev
Copy link
Collaborator

Irev-Dev commented Jul 9, 2024

Is this work still ongoing, or maybe we figured it was the wrong approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Desktop app shows bad network until a project is opened
4 participants