Fix incorrect extension dependency for Modf #3815
Open
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you submit a test that exercises this code path? As it stands, none of the existing tests are affected. |
|
It seems this condition should be unnecessary. If we have a half-precision operand, then wouldn't this capability have already been generated? Can't we just eliminate these two lines? |
eilswe-arm
force-pushed
the
fix-modf-dependency
branch
from
b894997 to
5442d79
Compare
|
After a look, I agree that the check is unnecessary, I removed it from the patch. I guess this removes the need for a test? There is already a test for 16bit float modf in glslang/Test/spv.float16.frag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue for details #3814