Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: fix linking of stubbed libraries #3811

Merged
merged 1 commit into from
Dec 15, 2024
Merged

cmake: fix linking of stubbed libraries #3811

merged 1 commit into from
Dec 15, 2024

Conversation

abouvier
Copy link
Contributor

Fix for #3709 (comment)

@arcady-lunarg
Copy link
Contributor

Just out of curiosity, are you linking glslang dynamically? Because that's one case I didn't really account for when I was testing the original change.

@arcady-lunarg arcady-lunarg added the kokoro:run Trigger Google bot runs label Dec 15, 2024
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Dec 15, 2024
@arcady-lunarg arcady-lunarg merged commit 8ad28db into KhronosGroup:main Dec 15, 2024
29 checks passed
@abouvier
Copy link
Contributor Author

glslang is compiled as a shared library with -DBUILD_SHARED_LIBS=ON and linked with target_link_libraries(app PRIVATE glslang::SPIRV).

@abouvier abouvier deleted the cmake-fix branch December 15, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcady-lunarg arcady-lunarg arcady-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abouvier @arcady-lunarg @kokoro-team