Emit correct name in debug info for scalar types #3323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sajjadmirzanv
force-pushed
the
basic-types-fix
branch
from
80bb403 to
562b6ca
Compare
|
Looks like automated testing is failing, could you please fix that and then I can review your change? |
commit 80bb403 Author: Sajjad Mirza <[email protected]> Date: Wed Aug 30 22:26:28 2023 +0100 Add MIT license to new file. commit df67700 Author: Sajjad Mirza <[email protected]> Date: Wed Aug 30 22:08:15 2023 +0100 Nonsemantic debug info emits correct name for scalar types.
sajjadmirzanv
force-pushed
the
basic-types-fix
branch
from
562b6ca to
824a703
Compare
Sorry about that, I have corrected the new test. In that job the Windows build should have failed (it has the same failing test as the Linux and MacOS builds), but instead it passed. Maybe there's a problem in the test runner? https://github.com/KhronosGroup/glslang/actions/runs/6030296198/job/16516875333?pr=3323#step:8:3581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SpvBuilder would name all integer types "int/uint" and all floating-point types "float". With this change it names 64-bit types to "double" to match the GLSL language spec, and other scalar types in accordance with GL_EXT_shader_explicit_arithmetic_types (e.g. "uint8_t").
This change only affects debug info when NonSemantic.Shader.DebugInfo.100 is requested.