Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Chinese version of overview #2451

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Oct 26, 2024

Follow-up from javagl/gltfOverview#11

@emackey
Copy link
Member

emackey commented Oct 28, 2024

(This may be out-of-scope for this PR, but I'm going to ask anyway...)

The Japanese and Chinese translation links here lead to direct downloads. It might be more friendly to link to the GitHub listing, or some kind of preview page where one could observe the material without being committed to save it in a local file and open from there. Would anyone object to changing these links to be something that would allow users to preview in their browsers as opposed to initiating a download?

@javagl
Copy link
Contributor Author

javagl commented Oct 28, 2024

Yeah, the "official" overview GitHub releases do include the "...small.png" that could be suitable for that (and is copied here to be shown in the README, with additional compression). These small ones don't exist for the Japanese and Chinese versions.

Even if the links here pointed to "...small.png" versions, people might be confused when clicking them ("Why so small?"). Maybe letting the links point directly to the "releases" at https://github.com/randall2835/gltfOverviewJapanese/releases/tag/v0.1 and https://github.com/leeyeel/gltfOverview-Chinese/releases/tag/v2.0.0d could be better. Otherwise: Do you have a preference where the "...small.png" versions could reside, and how to make clear that these are only previews for the real ones? (And where to include the PDFs - for zooming and/or printing, these are actually more important than the large PNGs...)

EDIT:

A middle-ground would be to have

[Japanese translation] (link pointing to `releases` folder) | [PDF] (link to PDF) | by [Author] (link to GitHub repo)

@javagl
Copy link
Contributor Author

javagl commented Oct 28, 2024

(Completely unrelated note to myself: https://github.com/KhronosGroup/glTF?tab=readme-ov-file#for-developers links to glTF-Sample-Models - this has been archived for a while, and should point to glTF-Sample-Assets. I'll fix this, but not now, to avoid concurrent changes to the README)

@emackey
Copy link
Member

emackey commented Oct 28, 2024

+1 for the "Middle ground" option you mentioned. It seems good to me.

@javagl
Copy link
Contributor Author

javagl commented Oct 30, 2024

@emackey Updated the links to point to the releases, and added the respective | PDF | link.

Direct preview:

https://github.com/javagl/glTF/tree/add-chinese-overview-links?tab=readme-ov-file#overview

Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @javagl.

@emackey emackey merged commit 2c5681a into KhronosGroup:main Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants