-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the 'force keeping channel for data' feature #2400
base: main
Are you sure you want to change the base?
Conversation
Hello, Seems your format options is not aligned with the ones that we are using here, and on Blender repository. |
Hello. Thank you for replying.
Could you please clarify why it is not possible to merge it for Blender 4.3.1? The changes are minor.
It should be fixed now. |
Branch freeze before the release will happen in a few hours |
In a few hours Blender 4.3 is going to be released if I'm not mistaken. It seems that Blender 4.4 is not expected until March 2025, which seems quite a long wait. I kindly hope that it might be possible to include this change in an earlier version (there will probably be at least 4.3.1?). Thank you for considering my request! |
Any 4.3.x is only for bug fixing. ( crashes & regression bugs) This will be merge in main branch that will become 4.4 |
I've realized that there is an issue. The animation pointer feature is currently only available in the "Scene" and "NLA tracks" modes. In these modes, all objects and data properties (when Animation Pointer is toggled) are sampled and baked, even when they are not animated by the user. As the result, using the "force keeping channel for objects/data" options causes every object and property (that can be exported via KHR_animation_pointer) to always have at least 2 keyframes and clutters resulting gltf files with multiple unnecessary channels. That seems to be the intended behavior. However, I'd like to only keep channels and keyframes for properties that I animate, which is currently impossible using those modes. So unfortunately this PR is not very useful for me at the moment unless it becomes possible to use Animation Pointer in the other modes or if some other changes are made. |
Implements the feature request #2386