Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather animation hook for all animations #2227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

y-khodja
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@julienduroure
Copy link
Collaborator

Hello,

There is already an gather_animation_hook hook in the code, you can not use the same name.
Root issue is that there are hooks for sampled export, but not for fcurves/not sampled ones. Not sure adding a new hook that will be performed for both cases is the best/right solution, as there will be 2 hooks for sampled, and only 1for not sampled.
Maybe it can be better to add proper hooks for not sampled export.
(And you can not say this is a hook for all animations, as your PR handle only "action" export mode, not NLA or Scene mode)

@julienduroure julienduroure self-requested a review May 14, 2024 18:48
@@ -426,6 +426,9 @@ def gather_action_animations( obj_uuid: int,
link_samplers(animation, export_settings)
animations.append(animation)

# export user extensions for all types of animation
export_user_extensions('gather_animation_hook', export_settings, animation, blender_action, blender_object)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a hook with the same name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this was a suggestion to encounter exported animations extension problem

@y-khodja
Copy link
Author

Hello,

Thank you for your answer, i now see the issue. I thought it would be better to have one hook that take in all animation export types as it would be used to add extensions or extras to the exported animation its self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants