Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader: QNX Screen WSI not supported for VulkanSC #39

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

aruby-blackberry
Copy link
Contributor

In VulkanSC, VK_USE_PLATFORM_SCREEN_QNX is indeed defined, as we are using QNX Screen external memory capabilities. However, this does not mean that WSI features of QNX Screen are supported (and they are not registered in the VulkanSC version of the spec).

Following the convention of the ifndef/endif VULKANSC for WIN32, xlib, etc.. platforms.

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@aqnuep aqnuep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution!

However, clang-format will fail this. Please run git clang-format on your change, or just use two spaces between #endif and // VULKANSC to make the CI format checks happy.

@aqnuep aqnuep merged commit ab7cbd1 into KhronosGroup:sc_main Apr 14, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants