build: Update to header 1.3.274 #7170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikes-lunarg
commented
Dec 19, 2023
mikes-lunarg
commented
- Update known-good
- Fix crash in extension_helper_generator when an extension has an explicit dependency on VK_VERSION_1_0
- Stub out safe struct constructor for VkPushDescriptorSetWithTemplateInfoKHR until it can be properly implemented Add safe struct for VkPushDescriptorSetWithTemplateInfoKHR Vulkan-Utility-Libraries#193
- VUID renames:
- VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283 -> 09465
- UNASSIGNED-vkCmdDrawIndirectByteCountEXT-counterOffset -> 09474
- UNASSIGNED-vkCmdDrawIndirectByteCountEXT-vertexStride -> 09475
- Fix video enums that got renamed EXT -> KHR
- Generate source
|
CI Vulkan-ValidationLayers build queued with queue ID 103846. |
|
CI Vulkan-ValidationLayers build # 14970 running. |
mikes-lunarg
force-pushed
the
v1.3.274_update
branch
from
3ddaf1d
to
9e6f1cf
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 103856. |
mikes-lunarg
commented
Dec 19, 2023
Comment on lines
+107
to
+109
| if reqs == 'VK_VERSION_1_0': | ||
| # An explicit dependency on Vulkan 1.0 is meaningless | ||
| continue |
There was a problem hiding this comment.
@spencer-lunarg Is this comment correct? Is it worth pushing back to the WG? As far as I can tell VK_KHR_maintenance6 is the first extension with depends="VK_VERSION_1_0" in the XML
There was a problem hiding this comment.
ya... feel that was an oversite, happy to take action with the WG to fix that
- Update known-good - Fix crash in extension_helper_generator when an extension has an explicit dependency on VK_VERSION_1_0 - Stub out safe struct constructor for VkPushDescriptorSetWithTemplateInfoKHR until it can be properly implemented #7169 - VUID renames: - VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283 -> 09465 - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-counterOffset -> 09474 - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-vertexStride -> 09475 - Fix video enums that got renamed EXT -> KHR - Generate source
|
CI Vulkan-ValidationLayers build # 14971 running. |
mikes-lunarg
force-pushed
the
v1.3.274_update
branch
from
9e6f1cf
to
efe607c
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 103867. |
|
CI Vulkan-ValidationLayers build # 14972 running. |
|
CI Vulkan-ValidationLayers build # 14972 passed. |
spencer-lunarg
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.