CMake: Added VUL_ENABLE_INSTALL to top level cmake file.
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows you to manually control the existance of the install target - defaults to VUL_IS_TOP_LEVEL to keep the original behavior without any changes to client code
| @@ -9,6 +9,11 @@ project(VUL LANGUAGES CXX) | |||
|
|
|||
| string(COMPARE EQUAL ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_SOURCE_DIR} VUL_IS_TOP_LEVEL) # Remove when min is 3.21 | |||
|
|
|||
| # Control whether to install or not. By default its only on if this is the top level cmake project. | |||
| if(NOT DEFINED VUL_ENABLE_INSTALL) | |||
There was a problem hiding this comment.
Why is an if statement put around the install code? Shouldn't making the install option be FALSE if VUL_IS_TOP_LEVEL is false be sufficient?
Put another way, we do not need to guard against the variable not existing before defining it. option() does not override the value if the variable already exists.
https://cmake.org/cmake/help/latest/command/option.html
There was a problem hiding this comment.
Good Question: If I recall correctly, its mainly to make the behavior consistent with older cmake versions: https://cmake.org/cmake/help/latest/policy/CMP0077.html#policy:CMP0077
I am not married to that check, if you think its too ugly, feel free to remove it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_subdirectory)VUL_IS_TOP_LEVELto keep the original behavior without any changes to existing client code.