Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safe struct for VkPushDescriptorSetWithTemplateInfoKHR #193

Open
mikes-lunarg opened this issue Dec 19, 2023 · 1 comment
Open

Add safe struct for VkPushDescriptorSetWithTemplateInfoKHR #193

mikes-lunarg opened this issue Dec 19, 2023 · 1 comment

Comments

@mikes-lunarg
Copy link
Contributor

mikes-lunarg commented Dec 19, 2023 •
edited by spencer-lunarg
Loading

VkPushDescriptorSetWithTemplateInfoKHR is part of VK_KHR_maintenance6 which appeared in the 1.1.274 header.

Currently stubbed out so we can build, but it needs a custom constructor which can copy pData correctly.

(Codegen assumed there was a dataCount member to get the length of pData and it failed to compile)
mikes-lunarg referenced this issue in mikes-lunarg/Vulkan-ValidationLayers Dec 19, 2023
@mikes-lunarg
build: Update to header 1.3.274
bb9744e 
- Update known-good
- Fix crash in extension_helper_generator when an extension has an explicit
  dependency on VK_VERSION_1_0
- Stub out safe struct constructor for VkPushDescriptorSetWithTemplateInfoKHR
  until it can be properly implemented #7169
- VUID renames:
  - VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283 -> 09465
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-counterOffset -> 09474
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-vertexStride -> 09475
- Generate source
mikes-lunarg referenced this issue in mikes-lunarg/Vulkan-ValidationLayers Dec 19, 2023
@mikes-lunarg
build: Update to header 1.3.274
3ddaf1d 
- Update known-good
- Fix crash in extension_helper_generator when an extension has an explicit
  dependency on VK_VERSION_1_0
- Stub out safe struct constructor for VkPushDescriptorSetWithTemplateInfoKHR
  until it can be properly implemented #7169
- VUID renames:
  - VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283 -> 09465
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-counterOffset -> 09474
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-vertexStride -> 09475
- Fix video enums that got renamed EXT -> KHR
- Generate source
@mikes-lunarg mikes-lunarg mentioned this issue Dec 19, 2023
Merged
mikes-lunarg referenced this issue in mikes-lunarg/Vulkan-ValidationLayers Dec 19, 2023
@mikes-lunarg
build: Update to header 1.3.274
9e6f1cf 
- Update known-good
- Fix crash in extension_helper_generator when an extension has an explicit
  dependency on VK_VERSION_1_0
- Stub out safe struct constructor for VkPushDescriptorSetWithTemplateInfoKHR
  until it can be properly implemented #7169
- VUID renames:
  - VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283 -> 09465
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-counterOffset -> 09474
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-vertexStride -> 09475
- Fix video enums that got renamed EXT -> KHR
- Generate source
mikes-lunarg referenced this issue in mikes-lunarg/Vulkan-ValidationLayers Dec 19, 2023
@mikes-lunarg
build: Update to header 1.3.274
efe607c 
- Update known-good
- Fix crash in extension_helper_generator when an extension has an
  explicit dependency on VK_VERSION_1_0
- Stub out safe struct constructor for
  VkPushDescriptorSetWithTemplateInfoKHR until it can be properly
implemented #7169
- VUID renames:
  - VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283 -> 09465
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-counterOffset -> 09474
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-vertexStride -> 09475
- Fix video enums that got renamed EXT -> KHR
- Generate source
spencer-lunarg referenced this issue in KhronosGroup/Vulkan-ValidationLayers Dec 20, 2023
@mikes-lunarg @spencer-lunarg
build: Update to header 1.3.274
9824359 
- Update known-good
- Fix crash in extension_helper_generator when an extension has an
  explicit dependency on VK_VERSION_1_0
- Stub out safe struct constructor for
  VkPushDescriptorSetWithTemplateInfoKHR until it can be properly
implemented #7169
- VUID renames:
  - VUID-VkDescriptorSetLayoutBinding-descriptorCount-00283 -> 09465
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-counterOffset -> 09474
  - UNASSIGNED-vkCmdDrawIndirectByteCountEXT-vertexStride -> 09475
- Fix video enums that got renamed EXT -> KHR
- Generate source
@spencer-lunarg spencer-lunarg self-assigned this Dec 20, 2023
@spencer-lunarg spencer-lunarg removed their assignment Jan 23, 2024
@spencer-lunarg spencer-lunarg self-assigned this Mar 6, 2024
@spencer-lunarg spencer-lunarg transferred this issue from KhronosGroup/Vulkan-ValidationLayers Apr 8, 2024
@spencer-lunarg spencer-lunarg removed their assignment Apr 8, 2024
@spencer-lunarg
Copy link
Contributor

Moved issued to VUL as Safe Struct now lives here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikes-lunarg @spencer-lunarg