Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main objective of this PR is to fix the
--headless
flag. Currently it does not work in the framework, due to not requesting a surface and swap chain.This PR reworks
HeadlessWindow
to make it more similar to the other window classes. This will allow us to enableVK_EXT_headless_surface
inHeadlessWindow::get_required_surface_extensions
like the other windows types. Now we can remove theheadless
paramater fromInstance::Instance
andVulkanSample<>::create_instance
simplifying the framework.To keep the samples
hello_world
andhpp_hello_world
as simple as possible, I did not add support for headless. Instead, an assert is run to ensure the are not enabling with headless in those samples.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlyFixes #830
Fixes #314