video encode: support more DPB image formats and usage limitations #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test cases do not need DPB images to support VK_IMAGE_USAGE_TRANSFER_SRC_BIT. This change reduces the usage flags to the necessary minimum. Affects: dEQP-VK.video.encode.*
The encoder test cases are not dependent on the DPB image format as they do not access the images. Still they required support for VK_FORMAT_G8_B8R8_2PLANE_420_UNORM. This change allows any image format requested by the implementation. It also changes some places were imageFormat was used instead of dpbImageFormat. Affects: dEQP-VK.video.encode.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use all image formats for DPB images. The video encode tests are not accessing the images, so they can support any image format.
Further, as the test cases do not access the images, only the usage flag
VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHRis necessary. I am not aware that implementations must supportVK_IMAGE_USAGE_TRANSFER_SRC_BIT, but maybe I am wrong here?Affects:
dEQP-VK.video.encode.*