Allow EGL 1.5 implementations without GL_KHR_robustness #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Driver may want to expose a minimal implementation of EGL_EXT_create_context_robustness - i.e. a dummy implementation without corresponding GL_KHR_robustness support - in order to support EGL 1.5. When requesting a context with EGL_CONTEXT_OPENGL_ROBUST_ACCESS_EXT -> EGL_TRUE on such a driver, it has to create a EGL_BAD_CONFIG error - and unfortunately there's no way to check for GL_KHR_robustness in advance. Thus handle that case gracefully.
|
|
rmader
commented
Aug 15, 2024
| m_testCtx.setTestResult(QP_TEST_RESULT_FAIL, "Fail"); | ||
| } | ||
| return STOP; | ||
| } |
There was a problem hiding this comment.
If preferred I can move this into a function in order to avoid duplication.
|
Specifically, this still allows querying of device reset status, without robust buffer access guarantees. |
|
There are a few more places that need to be covered. |
|
Nevermind and sorry for the noise - there were just some more issues in Mesa making tests fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver may want to expose a minimal implementation of EGL_EXT_create_context_robustness - i.e. a dummy implementation without corresponding GL_KHR_robustness support - in order to support EGL 1.5.
When requesting a context with EGL_CONTEXT_OPENGL_ROBUST_ACCESS_EXT -> EGL_TRUE on such a driver, it has to create a EGL_BAD_CONFIG error - and unfortunately there's no way to check for GL_KHR_robustness in advance.
Thus handle that case gracefully.
This should allow Mesa to expose 1.5 support for all drivers on all hardware generations.
Related: