correct failed output for direct_state_access.buffers_clear #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For R8* formats, the data is interpreted as non-numeric, so it messes with the log output. This change ensures the numbers are produced. Current outcome for R8* formats failure: The test of ClearNamedBufferData has failed for internalformat . Cleared buffer data is equal to [ After the fix: The test of ClearNamedBufferData has failed for internalformat . Cleared buffer data is equal to [0], but [5] was expected. Affects: KHR-GL46.direct_state_access.buffers_clear Change-Id: I9e9d771ba129464824df258d5a7066ac797b4c3a Signed-off-by: David Heidelberg <[email protected]>
okias
force-pushed
the
20240717-fix-fail-output
branch
from
20c9063
to
bfc4857
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct output for direct_state_access.buffers_clear when failure occurs
For R8* formats, the data is interpreted as non-numeric, so it messes
with the log output. This change ensures the numbers are produced.
Current outcome for R8* formats failure:
The test of ClearNamedBufferData has failed for internalformat . Cleared buffer data is equal to [
After the fix:
The test of ClearNamedBufferData has failed for internalformat . Cleared buffer data is equal to [0], but [5] was expected.
Affects:
KHR-GL46.direct_state_access.buffers_clear
Change-Id: I9e9d771ba129464824df258d5a7066ac797b4c3a