merge consecutive lines when stippling #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we draw the reference images, we split line segments into single-pixel length line segment, and we consider the stipple pattern for each segment individually. This leads to close to every covered pixel being considered an edge pixel, because we draw rectangles that are a single pixel long. We should merge the consecutive line segments before rasterizing them, so the filled portions are considered as a whole. Without this, the line-stippling tests are close to pointless; very close to every single covered pixel is allowed to be either filled or not, leading to very very few pixels actually being tested.
|
Here's an old MR I wrote when debugging CTS failures on Lavapipe... I guess it should be upstreamed. I don't expect this to cause any regressions on real drivers, because there are some pixels being tested per segment, and it would be very unlikely that a driver would cover those but not the ones that are completely uncovered by accident. But I haven't tested this on much HW. |
|
Ping? |
|
Hi @kusma I'm currently reviewing this MR. |
|
Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we draw the reference images, we split line segments into single-pixel length line segment, and we consider the stipple pattern for each segment individually. This leads to close to every covered pixel being considered an edge pixel, because we draw rectangles that are a single pixel long.
We should merge the consecutive line segments before rasterizing them, so the filled portions are considered as a whole.
Without this, the line-stippling tests are close to pointless; very close to every single covered pixel is allowed to be either filled or not, leading to very very few pixels actually being tested.