mutable dispatch related fixes #2143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck the test checks 'cl_khr_extended_versioning' then immediately calls: get_extension_version(device, "cl_khr_command_buffer_mutable_dispatch"); .. however, get_extension_version throws an exception when called with unsupported extension.
If mutable_dispatch extension is supported, the mutable handle is allowed to be not null. In that case, skip the HandleNotNull negative tests.
the test uses CL_MUTABLE_DISPATCH_ARGUMENTS_KHR, but does not check for support.
test MutableDispatchGlobalSize was failing (with an implementation that doesn't support non-uniform WGs), because the update_global_size = 3 was not a multiple of the local work-size. Fixed by increasing the global work-size to 256K and update size to 16K. This should work with all devices that have max_work_group_size <= 16K. Updates also MutableDispatchWorkGroups which had an out-of-bounds access, because it hardcoded the value of global work-size.
franz
force-pushed
the
mutable_dispatch_fixes
branch
from
c26f9eb
to
2cdd0eb
Compare
EwanC
requested changes
Nov 8, 2024
| { | ||
| if (CommandFillBaseTest::Skip()) return true; | ||
| return is_extension_available(device, | ||
| "cl_khr_command_buffer_mutable_dispatch"); |
There was a problem hiding this comment.
The mutable-dispatch extension affects kernel commands, not other types of commands. The spec wording for clCommandFillBufferKHR and other non-kernel command appending entry-points is:
- mutable_handle returns a handle to the command. This parameter is unused, and must be NULL."
The "must be NULL" part isn't conditional on the support for cl_khr_command_buffer_mutable_dispatch, so I don't think skipping here is correct. However, a future cl_khr_command_buffer_mutable_memory_commands extension could relax this for other types of commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.