kernel_image_methods: Fix size checks in 1Dbuffer case #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image height is initialized to 0. But the size calculation should assume a height of 1.
dneto0
commented
Oct 8, 2024
| @@ -262,8 +262,7 @@ int test_get_image_info_1D_buffer(cl_device_id device, cl_context context, | |||
| imageInfo.rowPitch += extraWidth; | |||
| } while ((imageInfo.rowPitch % pixelSize) != 0); | |||
|
|
|||
| size = (cl_ulong)imageInfo.rowPitch * (cl_ulong)imageInfo.height | |||
There was a problem hiding this comment.
imageInfo.height is initialized to 0 earlier, so the loop exits right away. The loop has not been doing anything useful. Change the calculation to use an assumed height of 1.
|
I think #2090 tries to fix this too, but this looks like a better fix IMHO. @lakshmih does this fix work for you? @dneto0 could you please fix the size calculation in test_1D.cpp also? I think it has the same problem. |
lakshmih
approved these changes
Oct 29, 2024
bashbaug
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image height is initialized to 0. But the size calculation should assume a height of 1.