Skip to content

Commit

Permalink
vulkan: Remove redundant negative testing (#2078)
Browse files Browse the repository at this point in the history
- negative testing for semaphore functions is accomplished in semaphore
tests, as well as create image in the api test

Co-authored-by: dcrawley <[email protected]>
  • Loading branch information
joshqti and dcrawley authored Nov 5, 2024
1 parent ef73a1d commit 5d4b51b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -158,16 +158,6 @@ int test_consistency_external_for_1dimage(cl_device_id deviceID,
test_error(errNum, "Unable to create Image with Properties");
image.reset();

// Passing properties, image_desc and image_format all as NULL
image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE, NULL,
NULL, NULL, &errNum);
test_failure_error(
errNum, CL_INVALID_IMAGE_DESCRIPTOR,
"Image creation must fail with CL_INVALID_IMAGE_DESCRIPTOR "
"when all are passed as NULL");

image.reset();

// Passing NULL properties and a valid image_format and image_desc
image =
clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,6 @@ int test_consistency_external_for_3dimage(cl_device_id deviceID,
test_error(errNum, "Unable to create Image with Properties");
image.reset();

// Passing properties, image_desc and image_format all as NULL
image = clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE, NULL,
NULL, NULL, &errNum);
test_failure_error(
errNum, CL_INVALID_IMAGE_DESCRIPTOR,
"Image creation must fail with CL_INVALID_IMAGE_DESCRIPTOR "
"when all are passed as NULL");

image.reset();

// Passing NULL properties and a valid image_format and image_desc
image =
clCreateImageWithProperties(context, NULL, CL_MEM_READ_WRITE,
Expand Down

0 comments on commit 5d4b51b

Please sign in to comment.