Fix JNI function name for getDataSizeUncompressed
#957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkCallow
reviewed
Nov 14, 2024
| @@ -599,4 +599,37 @@ public void testSupercompressionZLIB() throws IOException { | |||
|
|
|||
| t.destroy(); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Please add a comment similar to what you wrote in the PR description about this test.
There was a problem hiding this comment.
That certainly makes sense (otherwise, people might wonder what the purpose of the test is).
(An aside: In another context, I automated this kind of test, using some reflection magic - but here, we only have ~20 native functions, whereas for JCuda, it was about (literally) thousands of native methods in dozens of classes...)
|
Thanks @javagl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix for the JNI bindings:
The function signature for
getDataSizeUncompressedwas given asJava_org_khronos_KTXTexture_getDataSizeUncompressedbut must beJava_org_khronos_ktx_KtxTexture_getDataSizeUncompressed(matching the full package- and class name)Currently, calling this function would result in a
java.lang.UnsatisfiedLinkError: org.khronos.ktx.KtxTexture.getDataSizeUncompressed()JI also added a test that might look useless at the first glance: It just creates a texture, and calls all the
native"getter" functions on that (without any assertion). The point of that test is that it would have prevented this kind of error...