-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook 8 #1147
base: main
Are you sure you want to change the base?
Storybook 8 #1147
Conversation
Size Change: 0 B Total Size: 861 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 69.87% 70.45% +0.57%
==========================================
Files 513 516 +3
Lines 105884 106576 +692
Branches 7647 11808 +4161
==========================================
+ Hits 73987 75085 +1098
+ Misses 31711 31491 -220
+ Partials 186 0 -186 see 189 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
5e6d725
to
9d0e12f
Compare
package.json
Outdated
"@storybook/addon-actions": "^7.6.17", | ||
"@storybook/addon-controls": "^7.6.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actions, controls, and viewport addons are bundled into the "essentials" addon and so we don't need to depend on them separately.
9d0e12f
to
cb715a4
Compare
package.json
Outdated
"@storybook/addon-essentials": "^7.6.17", | ||
"@storybook/addon-links": "^7.6.17", | ||
"@storybook/addon-viewport": "^7.6.17", | ||
"@storybook/react": "^7.6.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@storybook/react"
is a dependency of "@storybook/react-vite"
so having a direct dependency is redundant.
package.json
Outdated
"style-loader": "^3.3.3", | ||
"typescript": "^5.4.2", | ||
"typescript-coverage-report": "^0.7.0", | ||
"vite-plugin-istanbul": "^5.0.0", | ||
"vite-plugin-turbosnap": "^1.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turbosnap is now built into the "@storybook/react-vite"
bundle and can be enabled with the standard --stats-json
argument (see line 146 of this file).
53f0784
to
b88ea8c
Compare
b88ea8c
to
c1b4365
Compare
…Storybook says it should be for v8
6db5d37
to
1800c31
Compare
Summary:
It kept prompting me, so I finally just did it.
One nice little thing is that Storybook 8 now bundles the Vite turbosnap functionality so when building storybook for Github Pages we can just pass a param instead of using a separate plugin.
Issue: "none"
Test plan:
yarn start
is happy