feat: add setting to turn off intelligent spacebar #1960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intelligent spacebar can now be turned on/off in settings.
Gauravjeetsingh
requested changes
Jun 3, 2024
| @@ -73,7 +73,7 @@ | |||
| "other-options": { | |||
| "title": "OTHER_OPTIONS", | |||
| "type": "switch", | |||
| "settings": ["limit-change-log", "statistics"] | |||
| "settings": ["limit-change-log", "statistics", "intelligent-spacebar"] | |||
There was a problem hiding this comment.
Small change, Instead of other options, can you please move this setting to App Settings.
|
Also, with multipane workspace we now have another file, which contains this code of intelligent switching. We might get rid of shabadContent.jsx file, in later releases, once we move on to this newer code for all workspaces. |
|
@Gauravjeetsingh bhaji, unfortunately, I won't have time (a few weeks) to make those changes. Please feel free to update my branch as desired! 🙏 |
|
Closing this out, as we have another PR for this #1989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1761 Intelligent spacebar can now be turned on/off in settings.
Preview:
sttm_fix.mov