Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to turn off intelligent spacebar #1761

Open
saintsoldierx opened this issue May 29, 2023 · 9 comments
Open

Add setting to turn off intelligent spacebar #1761

saintsoldierx opened this issue May 29, 2023 · 9 comments
Assignees

Comments

@saintsoldierx
Copy link
Collaborator

When off, it should always just go to home pankti

@Gauravjeetsingh Gauravjeetsingh self-assigned this May 31, 2023
@Gauravjeetsingh
Copy link
Collaborator

@saintsoldierx veerji, we can definetly do that, but I am a little hesistant in adding a setting for this. If the spacebar is not being used intelligently, maybe have two separate shortcuts? One for intelligent scrolling and keep space bar for home pankti?

It could be shift + space, its intelligent scrolling
or any other single key event, like i

@saintsoldierx
Copy link
Collaborator Author

No, i disagree - reason being is that spacebar is the most easiest key on the keyboard to use and our users are not only used to it, but it seems to be more intuitive than any other key. So i would say to add a setting for this and give users the option to switch.

@Gauravjeetsingh
Copy link
Collaborator

Gauravjeetsingh commented Jun 7, 2023

@saintsoldierx veerji, any idea on what could we call that setting, so that its self-explanatory to understand the usage?
"Intelligent spacebar" seems too general to use here.

@saintsoldierx
Copy link
Collaborator Author

@Gauravjeetsingh i am not sure what you mean. I would just have a setting that says "intelligent spacebar" which is the functionality we currently have and just have the option to turn it on or off?

@singh-sp
Copy link
Contributor

Waheguru ji,

I have the change ready that allows users to disable the (not so) "intelligent spacebar" feature. Note: I have left it enabled by default.

I am sure it has caused many others such a hassle since it was released. 😅- encountered numerous bugs (I was too lazy to report them).

Preview:

sttm_fix.mov

@saintsoldierx
Copy link
Collaborator Author

@singh-sp thank you, can you create a PR? I am wondering though why you don't like the intelligent spacebar feature? It's designed for Keertan where you can use it auto switch from asthaees to antras and back again easily.

@singh-sp
Copy link
Contributor

@singh-sp thank you, can you create a PR? I am wondering though why you don't like the intelligent spacebar feature? It's designed for Keertan where you can use it auto switch from asthaees to antras and back again easily.

Sure! I will create a PR tomorrow.

The reason we (myself and others) don't like it is because it forces you to follow a specific order. In reality, a Raagi can sing a shabad in *any order and may choose to revisit some panktis. When that happens, the spacebar becomes completely useless and out of sync, which is incredibly frustrating!

@saintsoldierx
Copy link
Collaborator Author

@singh-sp sure i get that. But surely it works in many situations too? Would it be beneficial then to have a shortcut as well to enable/disable it rather than going to settings each time?

@singh-sp
Copy link
Contributor

Perhaps it works for some folks, and that’s great!

Personally, I don’t feel confident using it after noticing many mistakes it has made, such as going to Salok or Paudi Panktis. Since the entire sangat is looking at the projector screen and our raagis rely on the monitor in front of them, it is crucial that we don’t display the wrong panktis. With intelligent spacebar, knowing which pankti it will select next is impossible—it’s a hit or miss. While we could add a UI indicator to show the next pankti, it might clutter the UI. I love the way the app works without it—total control.

So overall, it’s a permanent preference and, therefore, an option in settings suits better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants