Skip to content

Commit

Permalink
Merge pull request #1958 from Gauravjeetsingh/multi-pane-issues
Browse files Browse the repository at this point in the history
Multi pane issues
  • Loading branch information
Gauravjeetsingh committed Jun 4, 2024
2 parents f0aa3c5 + 88f1468 commit 6fad759
Show file tree
Hide file tree
Showing 3 changed files with 61 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packaging/update-packagejson.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const teamId = process.env.APPLE_TEAM_ID;

if (!teamId) {
console.error('TEAM_ID is not defined in the environment variables');
process.exit(1);
process.exit(0);
}

if (!process.env.I_AM_TRAVIS) {
Expand Down
19 changes: 17 additions & 2 deletions www/main/navigator/shabad/ShabadText.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ export const ShabadText = ({
setVerseHistory,
setActivePaneId,
setShortcuts,
setSundarGutkaBaniId,
setCeremonyId,
setIsCeremonyBani,
setIsSundarGutkaBani,
} = useStoreActions((actions) => actions.navigator);
const [activeVerse, setActiveVerse] = useState({});

Expand All @@ -83,6 +87,15 @@ export const ShabadText = ({
activeShabadId,
setActiveShabadId,
setPreviousIndex,
baniType,
sundarGutkaBaniId,
setSundarGutkaBaniId,
ceremonyId,
setCeremonyId,
isSundarGutkaBani,
setIsSundarGutkaBani,
isCeremonyBani,
setIsCeremonyBani,
});
udpateHistory(shabadId, newTraversedVerse, {
verseHistory,
Expand Down Expand Up @@ -163,8 +176,10 @@ export const ShabadText = ({
updateHomeVerse(initialVerseIndex);
setActiveVerse({ [activeVerseIndex]: activeVerseId });
}
if (activeShabadId === null) {
updateTraversedVerse(initialVerseId, initialVerseIndex);
if (activeShabadId === null && sundarGutkaBaniId === null && ceremonyId === null) {
if (initialVerseIndex >= 0) {
updateTraversedVerse(initialVerseId, initialVerseIndex);
}
}
}
}, [filteredItems]);
Expand Down
46 changes: 43 additions & 3 deletions www/main/navigator/shabad/utils/change-verse.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,51 @@ export const changeVerse = (
setActiveShabadId,
activeShabadId,
setPreviousIndex,
baniType,
sundarGutkaBaniId,
setSundarGutkaBaniId,
ceremonyId,
setCeremonyId,
isSundarGutkaBani,
setIsSundarGutkaBani,
isCeremonyBani,
setIsCeremonyBani,
},
) => {
if (clickedShabad !== activeShabadId) {
setActiveShabadId(clickedShabad);
setPreviousIndex(null);
if (baniType === 'bani') {
if (clickedShabad !== sundarGutkaBaniId) {
setSundarGutkaBaniId(clickedShabad);
setPreviousIndex(null);
}
if (!isSundarGutkaBani) {
setIsSundarGutkaBani(true);
}
if (isCeremonyBani) {
setIsCeremonyBani(false);
}
} else if (baniType === 'ceremony') {
if (clickedShabad !== ceremonyId) {
setCeremonyId(clickedShabad);
setPreviousIndex(null);
}

if (!isSundarGutkaBani) {
setIsSundarGutkaBani(true);
}
if (isCeremonyBani) {
setIsCeremonyBani(false);
}
} else if (baniType === 'shabad') {
if (clickedShabad !== activeShabadId) {
setActiveShabadId(clickedShabad);
setPreviousIndex(null);
}
if (isSundarGutkaBani) {
setIsSundarGutkaBani(false);
}
if (isCeremonyBani) {
setIsCeremonyBani(false);
}
}
setActiveVerse({ [verseIndex]: newTraversedVerse });
if (activeVerseId !== newTraversedVerse) {
Expand Down

0 comments on commit 6fad759

Please sign in to comment.