Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinSCP: Support for 'for you only' installations & other bug fixes #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sam97
Copy link
Contributor

@sam97 sam97 commented Dec 24, 2020

The current auto-detection strategy for paths does not consider installations in %APPDATA%, as well as a few other bugs that get in the way. This PR makes the following changes:

  • Fixes a bug in StartMenu detection which made it unusable.
  • Modifies StartMenu detection to also search for the shortcut in %APPDATA%\Microsoft\Windows\Start Menu\Programs.
  • Searches the registry under the HKCU root as well (for 'for you only' installations).

Fixes Keypirinha/Keypirinha#488.

@sam97
Copy link
Contributor Author

sam97 commented Dec 24, 2020

I've tested this using both 'for all users' and 'for you only' installations in a Windows Sandbox. The sessions and EXE detections seem to be working fine.

WinSCP/winscp.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

winScp sessions not listed
2 participants