Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality for remaining percentage (linux) #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

meepoSenpai
Copy link
Contributor

This should add functionality to also get the remaining battery percentages of all batteries on linux

@Kentzo
Copy link
Owner

Kentzo commented Jun 9, 2016

@meepoSenpai We should add implementation for get_remaining_percentage for all other platforms. Even if the implementation simply raises NotImplementedError.

@meepoSenpai
Copy link
Contributor Author

It should suffice to raise a NotImplementedError in the Superclass, correct?

@Kentzo
Copy link
Owner

Kentzo commented Jun 10, 2016

Since it's an @abstractmethod it has to be implemented.

@Kentzo
Copy link
Owner

Kentzo commented Oct 26, 2016

get_remaining_percentage must be implemented for Windows or Darwin before this can be merged.

@kootenpv
Copy link

I would say "Power" as a package is not complete until a few more things are being taken care of, such as get_remaining_percentage and get_time_remaining (which just works in an os-independent way).

@Kentzo
Copy link
Owner

Kentzo commented Oct 30, 2017

@kootenpv What is the difference between get_time_remaining_estimate and get_time_remaining?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants