Skip to content

Commit

Permalink
Remove vrfy job from rocoto workflow setup
Browse files Browse the repository at this point in the history
  • Loading branch information
KateFriedman-NOAA committed Nov 17, 2023
1 parent 3a7c355 commit 51b19f0
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 25 deletions.
1 change: 0 additions & 1 deletion workflow/applications/applications.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def __init__(self, conf: Configuration) -> None:
self.do_gempak = _base.get('DO_GEMPAK', False)
self.do_awips = _base.get('DO_AWIPS', False)
self.do_wafs = _base.get('WAFSF', False)
self.do_vrfy = _base.get('DO_VRFY', True)
self.do_verfozn = _base.get('DO_VERFOZN', True)
self.do_verfrad = _base.get('DO_VERFRAD', True)
self.do_vminmon = _base.get('DO_VMINMON', True)
Expand Down
3 changes: 1 addition & 2 deletions workflow/applications/gfs_cycled.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def _get_app_configs(self):
if self.do_ocean:
configs += ['ocnpost']

configs += ['sfcanl', 'analcalc', 'fcst', 'post', 'vrfy', 'arch', 'cleanup']
configs += ['sfcanl', 'analcalc', 'fcst', 'post', 'arch', 'cleanup']

if self.do_hybvar:
if self.do_jediatmens:
Expand Down Expand Up @@ -125,7 +125,6 @@ def get_task_names(self):
gdas_gfs_common_tasks_after_fcst = ['postanl', 'post']
# if self.do_ocean: # TODO: uncomment when ocnpost is fixed in cycled mode
# gdas_gfs_common_tasks_after_fcst += ['ocnpost']
gdas_gfs_common_tasks_after_fcst += ['vrfy']

gdas_gfs_common_cleanup_tasks = ['arch', 'cleanup']

Expand Down
5 changes: 1 addition & 4 deletions workflow/applications/gfs_forecast_only.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def _get_app_configs(self):
configs = ['stage_ic', 'fcst', 'arch', 'cleanup']

if self.do_atm:
configs += ['post', 'vrfy']
configs += ['post']

if self.do_aero:
configs += ['aerosol_init']
Expand Down Expand Up @@ -91,9 +91,6 @@ def get_task_names(self):
if self.do_ocean:
tasks += ['ocnpost']

if self.do_atm:
tasks += ['vrfy']

if self.do_atm and self.do_tracker:
tasks += ['tracker']

Expand Down
17 changes: 0 additions & 17 deletions workflow/rocoto/gfs_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -934,20 +934,6 @@ def genesis_fsu(self):

return task

def vrfy(self):
deps = []
dep_dict = {'type': 'metatask', 'name': f'{self.cdump}post'}
deps.append(rocoto.add_dependency(dep_dict))
dependencies = rocoto.create_dependency(dep=deps)

cycledef = 'gdas_half,gdas' if self.cdump in ['gdas'] else self.cdump

resources = self.get_resource('vrfy')
task = create_wf_task('vrfy', resources, cdump=self.cdump, envar=self.envars, dependency=dependencies,
cycledef=cycledef)

return task

def fit2obs(self):
deps = []
dep_dict = {'type': 'metatask', 'name': f'{self.cdump}post'}
Expand Down Expand Up @@ -1022,9 +1008,6 @@ def arch(self):
if self.cdump in ['gfs'] and self.app_config.do_genesis_fsu:
dep_dict = {'type': 'task', 'name': f'{self.cdump}genesis_fsu'}
deps.append(rocoto.add_dependency(dep_dict))
if self.app_config.do_vrfy:
dep_dict = {'type': 'task', 'name': f'{self.cdump}vrfy'}
deps.append(rocoto.add_dependency(dep_dict))
# Post job dependencies
dep_dict = {'type': 'metatask', 'name': f'{self.cdump}post'}
deps.append(rocoto.add_dependency(dep_dict))
Expand Down
2 changes: 1 addition & 1 deletion workflow/rocoto/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Tasks:
'aeroanlinit', 'aeroanlrun', 'aeroanlfinal',
'preplandobs', 'landanl',
'fcst', 'post', 'ocnpost',
'verfozn', 'verfrad', 'vminmon', 'vrfy', 'metp',
'verfozn', 'verfrad', 'vminmon', 'metp',
'tracker', 'genesis', 'genesis_fsu',
'postsnd', 'awips', 'gempak',
'waveawipsbulls', 'waveawipsgridded', 'wavegempak', 'waveinit',
Expand Down

0 comments on commit 51b19f0

Please sign in to comment.