Fix logging issues

KarlOfDuty · Dec 8, 2024 · c9b175c · c9b175c
1 parent 426c927
commit c9b175c
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 14 deletions.
diff --git a/Commands/AddStaffCommand.cs b/Commands/AddStaffCommand.cs
@@ -54,12 +54,23 @@ await command.RespondAsync(new DiscordEmbedBuilder
         cmd.ExecuteNonQuery();
         cmd.Dispose();
 
-        await command.RespondAsync(new DiscordEmbedBuilder
+        if (alreadyStaff)
         {
-            Color = DiscordColor.Green,
-            Description = alreadyStaff ? staffMember.Mention + " is already a staff member, refreshed username in database." : staffMember.Mention + " was added to staff."
-        }, true);
+            await command.RespondAsync(new DiscordEmbedBuilder
+            {
+                Color = DiscordColor.Green,
+                Description = staffMember.Mention + " is already a staff member, refreshed username in database."
+            }, true);
+        }
+        else
+        {
+            await command.RespondAsync(new DiscordEmbedBuilder
+            {
+                Color = DiscordColor.Green,
+                Description = staffMember.Mention + " was added to staff."
+            }, true);
 
-        await LogChannel.Success(staffMember.Mention + " was added to staff by " + command.User.Mention + ".");
+            await LogChannel.Success(staffMember.Mention + " was added to staff by " + command.User.Mention + ".");
+        }
     }
 }
diff --git a/Commands/NewCommand.cs b/Commands/NewCommand.cs
@@ -133,6 +133,11 @@ public static async Task CreateSelector(SlashCommandContext command, List<Databa
             return (false, "Error: Could not find the category to place the ticket in.");
         }
 
+        if (category.Children.Count == 50)
+        {
+            return (false, "This ticket category is full, can not create ticket channel.");
+        }
+
         DiscordMember member = null;
         try
         {
@@ -151,7 +156,10 @@ public static async Task CreateSelector(SlashCommandContext command, List<Databa
         {
             ticketChannel = await category.Guild.CreateChannelAsync("ticket", DiscordChannelType.Text, category);
         }
-        catch (Exception) { /* ignored */ }
+        catch (Exception e)
+        {
+            Logger.Error("Error occured while creating ticket.", e);
+        }
 
         if (ticketChannel == null)
         {
@@ -173,7 +181,7 @@ public static async Task CreateSelector(SlashCommandContext command, List<Databa
         catch (DiscordException e)
         {
             Logger.Error("Exception occurred trying to modify channel: " + e);
-            Logger.Error("JsomMessage: " + e.JsonMessage);
+            Logger.Error("JsonMessage: " + e.JsonMessage);
         }
 
         try
@@ -183,7 +191,7 @@ public static async Task CreateSelector(SlashCommandContext command, List<Databa
         catch (DiscordException e)
         {
             Logger.Error("Exception occurred trying to add channel permissions: " + e);
-            Logger.Error("JsomMessage: " + e.JsonMessage);
+            Logger.Error("JsonMessage: " + e.JsonMessage);
         }
 
         DiscordMessage message = await ticketChannel.SendMessageAsync("Hello, " + member.Mention + "!\n" + Config.welcomeMessage);
@@ -230,7 +238,7 @@ await assignedStaff.SendMessageAsync(new DiscordEmbedBuilder
                 catch (DiscordException e)
                 {
                     Logger.Error("Exception occurred assign random staff member: " + e);
-                    Logger.Error("JsomMessage: " + e.JsonMessage);
+                    Logger.Error("JsonMessage: " + e.JsonMessage);
                 }
             }
         }

diff --git a/EventHandler.cs b/EventHandler.cs
@@ -288,7 +288,7 @@ public static async Task OnComponentInteractionCreated(DiscordClient client, Com
         catch (DiscordException ex)
         {
             Logger.Error("Interaction Exception occurred: " + ex);
-            Logger.Error("JsomMessage: " + ex.JsonMessage);
+            Logger.Error("JsonMessage: " + ex.JsonMessage);
         }
         catch (Exception ex)
         {

diff --git a/LogChannel.cs b/LogChannel.cs
@@ -38,25 +38,24 @@ private static async Task Log(DiscordColor color, string message, uint ticketID
 
     try
     {
-      DiscordChannel logChannel = await SupportBoi.client.GetChannelAsync(Config.logChannel);
-
-      DiscordMessageBuilder messageBuilder = new();
       DiscordEmbedBuilder embedBuilder = new()
       {
         Color = color,
         Description = message
       };
-
       if (ticketID != 0)
       {
         embedBuilder.WithFooter("Ticket: " + ticketID.ToString("00000"));
       }
 
+      DiscordMessageBuilder messageBuilder = new();
+      messageBuilder.AddEmbed(embedBuilder);
       if (file != null)
       {
         messageBuilder.AddFile(file.fileName, file.contents);
       }
 
+      DiscordChannel logChannel = await SupportBoi.client.GetChannelAsync(Config.logChannel);
       await logChannel.SendMessageAsync(messageBuilder);
     }
     catch (NotFoundException)