Allowing admin users to change users email #3118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majora2007
requested changes
Aug 21, 2024
| // Validate email change | ||
| var emailValidationErrors = await _accountService.ValidateEmail(dto.Email); | ||
| if (emailValidationErrors.Any()) return BadRequest(await _localizationService.Translate(User.GetUserId(), "email-taken")); | ||
| user.Email = dto.Email; |
There was a problem hiding this comment.
You need a new line after the if statement to help the code be easier to digest.
API/Controllers/AccountController.cs
Outdated
| user.Email = dto.Email; | ||
| user.EmailConfirmed = false; | ||
| user.NormalizedEmail = _userManager.NormalizeEmail(dto.Email); | ||
| user.ConfirmationToken = await _userManager.GenerateEmailConfirmationTokenAsync(user); |
There was a problem hiding this comment.
You generate a confirmation token, but I don't see you triggering an email for the end user to confirm and get rid of that pending status.
|
Not sure if you still want to work on this to get it in? |
Added new line as requested Removed the confirmation token since if the admin is changing the users email, it should be a force change. Set the `EmailConfirmed` status to `True`, again since the admin is the one pushing it through.
|
Changes made. Got rid of the email confirmation step because it is an admin making the change. That should force change it and not rely on the confirmation flow. Not sure what I was thinking before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed