-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP client and API interface #194
Open
AlphaKeks
wants to merge
13
commits into
KZGlobalTeam:dev
Choose a base branch
from
AlphaKeks:http
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlphaKeks
force-pushed
the
http
branch
6 times, most recently
from
July 5, 2024 18:12
7cf241d
to
458886a
Compare
laomuon
reviewed
Jul 7, 2024
zer0k-z
reviewed
Jul 7, 2024
AlphaKeks
force-pushed
the
http
branch
2 times, most recently
from
July 29, 2024 19:02
8f93f1f
to
ab3943a
Compare
zer0k-z
requested changes
Aug 4, 2024
zer0k-z
requested changes
Aug 4, 2024
zer0k-z
reviewed
Aug 4, 2024
zer0k-z
requested changes
Aug 5, 2024
Comment on lines
+763
to
+786
|
||
CNetworkGameServerBase *networkGameServer = (CNetworkGameServerBase *)g_pNetworkServerService->GetIGameServer(); | ||
|
||
if (networkGameServer != nullptr) | ||
{ | ||
KZGlobalService::Hook_ActivateServer(networkGameServer->GetMapName()); | ||
} | ||
|
||
interfaces::pEngine->ServerCommand("exec cs2kz.cfg"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
CNetworkGameServerBase *networkGameServer = (CNetworkGameServerBase *)g_pNetworkServerService->GetIGameServer(); | |
if (networkGameServer != nullptr) | |
{ | |
KZGlobalService::Hook_ActivateServer(networkGameServer->GetMapName()); | |
} | |
interfaces::pEngine->ServerCommand("exec cs2kz.cfg"); |
It's already in kz_misc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not? Do you mean that there's already a OnServerActivate
function and I should move it there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85