Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Issue 1930: Fixed type from char to int #1932

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

martinjankoehler
Copy link
Contributor

Fixes issue #1930

@klayoutmatthias
Copy link
Collaborator

Ah, the famous "char is signed or unsigned" problem :)

I thought that has been settled as clang and gcc treat it the signed on both Linux and Windows, but ARM appears to be an exception.

Usually I try to avoid that, but here it escaped me. "signed char" would have solved the issue too, but now we're prepared for line widths >=128. Lovely :)

Thanks for the patch.

Best regards,

Matthias

@klayoutmatthias
Copy link
Collaborator

P.S. I don't know why, but the Azure builds are randomly failing while trying to download the Windows build bits.

@klayoutmatthias klayoutmatthias merged commit 6c7a3f6 into KLayout:master Nov 19, 2024
12 of 17 checks passed
@martinjankoehler martinjankoehler deleted the bugfix/issue-1930 branch November 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants