Chat recording changes #26
Conversation
|
Thanks for the changes.
It will be difficult to read the chat with all the private messages when there are a lot of players in a replay. |
|
Sorry for late reply, I'll fix 1 and test 3. 2 is probably a design problem because when you are recording 2 or more players, some users expect it to replay everything in players' chats, others expect another behavior. Maybe I will add something like "record only everything in my chat" to configuration, but the chat recording configuration is already a bit complicated, so I think the better design option would be "chat recording mode: DISABLED / CHAT / EVERYTHING IN CHAT / EVERYTHING IN EVERYONES CHAT", or maybe you have better configuration ideas? |
|
I can't think of any use case where you would want so see the same message twice. It might make more sense to record specific private or global messages from the plugin that sends them (with the API). Otherwise how would you know if the message is a global announcement (should only be displayed once) or a message that can be displayed multiple times. |
|
Do you mean all plugins should work with AdvancedReplay's API or vice versa or what? |
|
That could work but I would probably not show the player names with global announcements. |
|
I came up with the use of HoverEvent for displaying message recipients, so it doesn't take additional space and makes it easy to check which players were online at the moment. "everything" was renamed to "plugin_messages" so it makes sense for end users. Also it works with replays saved in older versions (and even displays messages!). There are some minor cosmetic bugs (e.g. messages saved in old replays are gray, join/leave/death messages don't show recipients when recording them from events ("plugin_messages" is turned off)), I'll fix them tomorrow. |
|
Are join, quit and death events plugin or chat messages? They are recorded even if both options are set to false but will only be replayed when both are enabled. I think message duplicates should be filtered while recording to avoid storing unnecessary data. It seems like some of your changes broke the reset_changes config option from a recent update. |
They are chat messages because they're more useful than players' command feedback.
Oh, I did something with config conditionals that now I don't even know what I did, now they should be clear.
Fixed.
Done.
It doesn't work on master for me (or maybe I don't understand what exactly it should do, but the blocks don't disappear after the end of the replay). |
|
Why are messages sometimes recorded in messages and sometimes in actions? |
|
They're recorded in messages when they're recorded as packets and we need to compress messages, there's no need to do this in event listener recorders. But yes, it would be better to record them in messages to simplify the code. |
|
|
||
| WrapperPlayServerChat packet = new WrapperPlayServerChat(event.getPacket()); | ||
|
|
||
| String message = new TextComponent(ComponentSerializer.parse(packet.getMessage().getJson())).toLegacyText(); |
There was a problem hiding this comment.
I did some tests on Spigot 1.8.8 and there is an error message with plugin_messages enabled while trying to record death messages. I think the ComponentSerializer cannot parse the message.
[17:53:59 ERROR]: [AdvancedReplay] Unhandled exception occured in onPacketSending(PacketEvent) for AdvancedReplay java.lang.IllegalArgumentException: No enum constant net.md_5.bungee.api.chat.HoverEvent.Action.SHOW_ENTITY at java.base/java.lang.Enum.valueOf(Unknown Source) ~[?:?] at net.md_5.bungee.api.chat.HoverEvent$Action.valueOf(HoverEvent.java:16) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.BaseComponentSerializer.deserialize(BaseComponentSerializer.java:71) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.TextComponentSerializer.deserialize(TextComponentSerializer.java:25) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.TextComponentSerializer.deserialize(TextComponentSerializer.java:17) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:803) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:868) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson$1.deserialize(Gson.java:126) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.ComponentSerializer.deserialize(ComponentSerializer.java:62) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.ComponentSerializer.deserialize(ComponentSerializer.java:17) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:803) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:868) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson$1.deserialize(Gson.java:126) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.TranslatableComponentSerializer.deserialize(TranslatableComponentSerializer.java:28) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.TranslatableComponentSerializer.deserialize(TranslatableComponentSerializer.java:16) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:803) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:868) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson$1.deserialize(Gson.java:126) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.ComponentSerializer.deserialize(ComponentSerializer.java:60) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.ComponentSerializer.deserialize(ComponentSerializer.java:17) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.TreeTypeAdapter.read(TreeTypeAdapter.java:58) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:803) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:768) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:717) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at com.google.gson.Gson.fromJson(Gson.java:689) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.md_5.bungee.chat.ComponentSerializer.parse(ComponentSerializer.java:34) ~[spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at me.jumper251.replay.replaysystem.recording.PacketRecorder$1.onPacketSending(PacketRecorder.java:317) ~[Replay.jar:?] at com.comphenix.protocol.injector.SortedPacketListenerList.invokeSendingListener(SortedPacketListenerList.java:195) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketSending(SortedPacketListenerList.java:149) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.PacketFilterManager.handlePacket(PacketFilterManager.java:588) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.PacketFilterManager.invokePacketSending(PacketFilterManager.java:564) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.ProtocolInjector.packetQueued(ProtocolInjector.java:338) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.ProtocolInjector.onPacketSending(ProtocolInjector.java:298) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.ChannelInjector.processSending(ChannelInjector.java:378) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.ChannelInjector.access$800(ChannelInjector.java:64) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.ChannelInjector$3.handleScheduled(ChannelInjector.java:343) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.ChannelInjector$3.onMessageScheduled(ChannelInjector.java:313) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.ChannelProxy$2.schedulingRunnable(ChannelProxy.java:127) [ProtocolLib-S4.jar:4.5.0] at com.comphenix.protocol.injector.netty.EventLoopProxy.execute(EventLoopProxy.java:95) [ProtocolLib-S4.jar:4.5.0] at net.minecraft.server.v1_8_R3.NetworkManager.a(NetworkManager.java:192) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.NetworkManager.handle(NetworkManager.java:141) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PlayerConnection.sendPacket(PlayerConnection.java:907) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PlayerList.sendAll(PlayerList.java:880) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PlayerList.sendMessage(PlayerList.java:1192) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PlayerList.sendMessage(PlayerList.java:1197) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityPlayer.die(EntityPlayer.java:423) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityLiving.damageEntity(EntityLiving.java:812) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityHuman.damageEntity(EntityHuman.java:800) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityPlayer.damageEntity(EntityPlayer.java:496) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityLiving.e(EntityLiving.java:939) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityHuman.e(EntityHuman.java:1440) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.Block.fallOn(Block.java:640) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.Entity.a(Entity.java:811) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityLiving.a(EntityLiving.java:160) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.EntityPlayer.a(EntityPlayer.java:621) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PlayerConnection.a(PlayerConnection.java:456) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PacketPlayInFlying.a(SourceFile:126) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PacketPlayInFlying$PacketPlayInPosition.a(SourceFile:57) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.PlayerConnectionUtils$1.run(SourceFile:13) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) [?:?] at java.base/java.util.concurrent.FutureTask.run(Unknown Source) [?:?] at net.minecraft.server.v1_8_R3.SystemUtils.a(SourceFile:44) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:715) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:374) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:654) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:557) [spigot_server-1.8.8-R0.1-SNAPSHOT-latest.jar:git-Spigot-db6de12-18fbb24] at java.base/java.lang.Thread.run(Unknown Source) [?:?] [17:53:59 ERROR]: Parameters: net.minecraft.server.v1_8_R3.PacketPlayOutChat@7909c818[ a=TranslatableComponent{key='death.fell.accident.generic', args=[TextComponent{text='Jumper251', siblings=[], style=Style{hasParent=true, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=ClickEvent{action=SUGGEST_COMMAND, value='/msg Jumper251 '}, hoverEvent=HoverEvent{action=SHOW_ENTITY, value='TextComponent{text='{name:"Jumper251",id:"28bc683e-40e9-47bc-a1fb-e067b77d8262"}', siblings=[], style=Style{hasParent=false, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=null, hoverEvent=null, insertion=null}}'}, insertion=Jumper251}}], siblings=[], style=Style{hasParent=false, color=null, bold=null, italic=null, underlined=null, obfuscated=null, clickEvent=null, hoverEvent=null, insertion=null}} components=<null> b=1 ]
Resolves: #12