Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped <error> tag in a <testcase> for XML output #98

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

gbruer15
Copy link
Contributor

Closes #97

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (f228a7a) to head (54191fb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   94.69%   96.40%   +1.71%     
==========================================
  Files           7        7              
  Lines         547      557      +10     
==========================================
+ Hits          518      537      +19     
+ Misses         29       20       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbruer15
Copy link
Contributor Author

@oxinabox This is ready to merge, other than the failing tests that are outside the scope of this MR. Can you review it.

The test on Julia 1.10 is failing, but the tests on Julia 1.0, 1.6, and 1.12-nightly are passing and locally testing on 1.8 works fine.

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right
@mmiller-max did you know what is up with the failing test cases?

@omus
Copy link
Member

omus commented Apr 26, 2024

Failure here should be addressed by #99

@oxinabox
Copy link
Member

@gbruer15 can you rebase this against current master, and that should catch what was fixed in #99 and so we should be able to merge this.

@mmiller-max
Copy link
Member

This looks right @mmiller-max did you know what is up with the failing test cases?

Sorry I missed this. Thanks for fixing @omus

@gbruer15
Copy link
Contributor Author

@oxinabox This is ready to merge now.

@oxinabox oxinabox merged commit 345a4c0 into JuliaTesting:master Apr 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect JUnit XML for error outside of test case
4 participants