-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapped <error> tag in a <testcase> for XML output #98
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 94.69% 96.40% +1.71%
==========================================
Files 7 7
Lines 547 557 +10
==========================================
+ Hits 518 537 +19
+ Misses 29 20 -9 ☔ View full report in Codecov by Sentry. |
@oxinabox This is ready to merge, other than the failing tests that are outside the scope of this MR. Can you review it. The test on Julia 1.10 is failing, but the tests on Julia 1.0, 1.6, and 1.12-nightly are passing and locally testing on 1.8 works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right
@mmiller-max did you know what is up with the failing test cases?
Failure here should be addressed by #99 |
Sorry I missed this. Thanks for fixing @omus |
@oxinabox This is ready to merge now. |
Closes #97