V2.0 #19
Open
V2.0 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving, dividing src code in utils/potentials/dfs/mappings Adding: - benchmarks to run locally - tests and CI
Removed test of undefined analytic inversion J,L -> a,e Fix initial guess in numerical inversion J,L -> a,e (allocations fixed)
Prevent `_extremise_noedges` from looking outside the fixed boundaries when refining the bisection (line 120 in src/mapping/utils/extremise.jl
Adapt all analytic isochrone mapping function to v2.0
…encies!) Issue with azimuthal frequency : anomaly definition in Theta(u) vs r(u) not the same due to sp, sa energy and action tested (forward and backward)
Check resonant boundaries functions by comparing analytic (Jean-Baptiste) versions for Isochrone and generic version
Issue at frequency exactly 0 for some resonances to fix later
…s in CARP) +Add dependencies on model and parameters for circular functions to help overwritting for some specific potentials
define angles_gradient w.r.t. anomaly and export it + radius from anomaly function
Update to v4 of codecov action + adding secret token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have implemented a massive overhaul in the structure. The goal is to make everything much more modular and more useful to external software packages.