Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank ForwardDiff 0.10.33 #73304

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Yank ForwardDiff 0.10.33 #73304

merged 1 commit into from
Dec 2, 2022

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Dec 2, 2022

This turns out to cause more disruption than intended, so perhaps it should be 0.11 not a patch version.

The offending PR is JuliaDiff/ForwardDiff.jl#481

Some reports of issues aren't issues, but the ones that are are:
JuliaDiff/ForwardDiff.jl#606
JuliaDiff/ForwardDiff.jl#607
JuliaDiff/ForwardDiff.jl#609

@giordano giordano added the yank label Dec 2, 2022
@giordano giordano merged commit 8fb2ee4 into JuliaRegistries:master Dec 2, 2022
@mcabbott mcabbott deleted the patch-2 branch December 2, 2022 12:42
@oxinabox
Copy link
Contributor

oxinabox commented Dec 2, 2022

I think this case it would have been better to just revert and release 0.10.34, without yanking 0.10.33

Like all patch releases, (though not true pre-1.0.0) the older version had bugs.
But we don't yank all penultimate patch versions. (Though I have suggested that Pkg should by default treat them that way, but that's another dicussion)

The particular thing that yanking does that just making a new release doesn't is it means you can do ]add --preserve=all Foo for minimal changes to a known working system. (nor update ---preserve=all Foo in 1.9 I suspect).
And this broke stuff for Invenia's workflow trying to make minimal changes to prod.

@mcabbott
Copy link
Contributor Author

mcabbott commented Dec 2, 2022

Well IDK, there appear to be many opinions. Want to make a branch for 0.10 versions & tag that as 0.10.34?

Reverting things seems to be a way to make sure they rot.

@oxinabox
Copy link
Contributor

oxinabox commented Dec 5, 2022

revert release patch, then unrevert and release breaking IMO is best

Well IDK, there appear to be many opinions. Want to make a branch for 0.10 versions & tag that as 0.10.34?

It wouldn't help. The problem is the yanking of 0.10.33 being more disruptive than just releasing a 0.10.34 that is identical to 0.10.32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants